Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: YAML.dump quotes y when dumping #164

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: YAML.dump quotes y when dumping #164

merged 1 commit into from
Apr 30, 2024

Conversation

kamranf
Copy link
Contributor

@kamranf kamranf commented Apr 30, 2024 •
edited
Loading

Per ruby/psych#443 we need to manually convert y in the dumped file to be consistent with other fields returned from Datadog i.e.

irb(main):032> {"layout"=>{"x"=>20, "y"=>6}}.to_yaml
=> "---\nlayout:\n  x: 20\n  \"y\": 6\n"

irb(main):035> {"layout"=>{"x"=>20, "y"=>6}}.to_yaml.gsub('"y":','y:' )
=> "---\nlayout:\n  x: 20\n  y: 6\n"

@kamranf kamranf marked this pull request as ready for review April 30, 2024 03:17
@kamranf kamranf merged commit f1d6e0d into main Apr 30, 2024
16 checks passed
@kamranf kamranf deleted the kamranf/fix-yaml-dump-bug branch April 30, 2024 03:19
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@semantic-release-bot
chore(release): 4.0.1 [skip ci]
1475d9a 
## [4.0.1](v4.0.0...v4.0.1) (2024-04-30)

### Bug Fixes

* YAML.dump quotes y when dumping ([#164](#164)) ([f1d6e0d](f1d6e0d))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kamranf