Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEF-3223] Add Kafka PubSub and Kafka transport clients #102

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Apr 16, 2024

Description

In this PR we move Kafka-related code from the go-chassis.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner April 16, 2024 14:50
@Neurostep Neurostep requested a review from helenff April 16, 2024 14:50
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

I trust that you copy/pasted the files correctly. 😄

Do we need to anything in the docs related to PubSub and Kafka? If this needs to be done, I'm OK if you wanna create a Jira and do it in a separate PR.

Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📦

@Neurostep
Copy link
Contributor Author

@fotos

Do we need to anything in the docs related to PubSub and Kafka? If this needs to be done, I'm OK if you wanna create a Jira and do it in a separate PR.

It is a part of the GUIDE.md of the go-chassis and updated in a corresponding PR. Let me know if you think we need to expand the README file of the go-sdk, I will create a corresponding ticket for that 👍

@Neurostep Neurostep merged commit 1b198c4 into main Apr 17, 2024
7 checks passed
@Neurostep Neurostep deleted the maksimt/SERF-3223/kafka-client branch April 17, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants