[SERF-3255] Add Redis client configuration and instrumentation #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fotos
reviewed
Apr 19, 2024
There was a problem hiding this comment.
I did a really quick pass – will remove the documentation next week.
Overall it looks great – left 2 small comments.
Thank you @Neurostep! 🌮
Neurostep
force-pushed
the
maksimt/MLD-6274/redis-client
branch
from
11a229c
to
40f3beb
Compare
laynax
reviewed
Apr 22, 2024
Neurostep
force-pushed
the
maksimt/MLD-6274/redis-client
branch
from
40f3beb
to
82666f5
Compare
Neurostep
force-pushed
the
maksimt/MLD-6274/redis-client
branch
from
82666f5
to
07f0a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we introduce a new configuration and instrumentation package: Redis.
We use official go-redis client and the dd-trace-go wrapper for instrumentation.
PLEASE NOTE: in this PR we have to upgrade a few widely used libraries, such as
dd-trace-goandaws-sdk-go. This is the case because thego-rediswrapper in thedd-trace-golibrary is supported in the later versions only. Upgrade of thedd-trace-gotransitively upgraded theaws-sdk-go. All upstream services will be carefully tested with this change.Testing considerations
go-chassisand check tracesChecklist
developmentand/orstagingREADME.mdas necessaryRelated links