Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-3477] Upgrade to Golang version 1.23.0 #125

Merged
merged 4 commits into from
Aug 22, 2024
Merged

[SERF-3477] Upgrade to Golang version 1.23.0 #125

merged 4 commits into from
Aug 22, 2024

Conversation

laynax
Copy link
Contributor

@laynax laynax commented Aug 22, 2024 •
edited
Loading

Description

This:

  • Updates Golang version to v1.23
  • Updates golangci-lint to v1.60.1
  • Update goimports to v0.24.0
  • Update delve to v1.23.0
  • Updates alpine to version 3.20.2

Testing considerations

No error running docker-compose run --rm sdk mage test:run
No error running tests using this go-sdk branch

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@laynax laynax requested a review from a team as a code owner August 22, 2024 12:01
@laynax laynax requested a review from fotos August 22, 2024 12:01
@laynax laynax requested a review from Neurostep August 22, 2024 13:04
Neurostep
Neurostep approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@laynax laynax merged commit b634119 into main Aug 22, 2024
7 checks passed
@laynax laynax deleted the laynax/SERF-3477/go123 branch August 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neurostep Neurostep Neurostep approved these changes

@fotos fotos Awaiting requested review from fotos fotos is a code owner automatically assigned from scribd/service-foundations

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laynax @Neurostep