Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-2048] Relax the requirement in PR commit message check workflow #81

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[SERF-2048] Relax the requirement in PR commit message check workflow #81

merged 1 commit into from
Jul 6, 2023

Conversation

azclub
Copy link
Contributor

@azclub azclub commented Jul 5, 2023 •
edited by jira bot
Loading

Description

Allow commit messages to start with a lowercase letter as that conforms with the Angular commit message convention.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@azclub azclub requested a review from a team as a code owner July 5, 2023 15:03
@azclub azclub requested a review from fotos July 5, 2023 15:03
terranisu
terranisu approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azclub azclub merged commit 11583b5 into main Jul 6, 2023
@azclub azclub deleted the helen/SERF-2048/commit-message-check branch July 6, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terranisu terranisu terranisu approved these changes

@fotos fotos Awaiting requested review from fotos fotos is a code owner automatically assigned from scribd/service-foundations

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azclub @terranisu @helenff