Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version to ui along with releases github page link #505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mehul721
Copy link

#504 Version needs to be converted to an external link to directs towards the releases on GitHub

  • This pull request is on a [feat/feedback-and-support] and not the main branch

Description

Copy link

github-actions bot commented Sep 29, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CI unit test workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Looks like there are some errors with the build here :)

xcodebuild: error: Could not resolve package dependencies:
  package 'grdb.swift' @ dc03b8a29e2f5d51bd41e0971bba9a9975a29934 is using Swift tools version 6.0.0 but the installed version is 5.10.0 in https://github.com/groue/GRDB.swift.git

package 'grdb.swift' @ dc03b8a29e2f5d51bd41e0971bba9a9975a29934 is using Swift tools version 6.0.0 but the installed version is 5.10.0 in https://github.com/groue/GRDB.swift.git

Let us know if you have any thoughts on how to fix this, @Mehul721! Happy to support if you need assistance with them :)

@Mehul721
Copy link
Author

Hello.I think the issue is migrating from swift 5.10.0 to 6.0.0.I am facing a lot of build issues because of that.Could you help me in any way?

@andrewtavis
Copy link
Member

Hmmm, yes I'm realizing just now that there's been a major version update. Maybe the thing to do is for this we can set the tests to Swift 5.10.0 and then update to Swift 6.0.0 in a new issue 🤔 Pinging @fabulouiOS-monk for a quick opinion here, if you have a moment :)

@fabulouiOS-monk
Copy link
Collaborator

There are two ways: 1. to make use of 6.0 in the github action file.
2. To downgrade the GRDB swift version (which I think is a hassle)

Let's try with the 1st way: @Mehul721 can you please attach the following to pr_ci.yml file:

  • name: Install Swift 6.0.0
    uses: fwal/setup-swift@v1
    with:
    swift-version: '6.0.0'

    Note: You will find the pr_ci.yml file in hidden folder **.github > workflows> pr_ci.yaml**

@Mehul721
Copy link
Author

Mehul721 commented Oct 1, 2024

  • name: Install Swift 6.0.0
    uses: fwal/setup-swift@v1
    with:
    swift-version: '6.0.0'

Hi so I have just updated the pr_ci.yml file.Kindly have a look.

@andrewtavis
Copy link
Member

Did you push the changes, @Mehul721? I'm seeing just one commit on this PR still :)

@Mehul721
Copy link
Author

Mehul721 commented Oct 1, 2024

I created a new PR for that.Still please let me know in case of an issue.

@fabulouiOS-monk
Copy link
Collaborator

@Mehul721 can you please share the PR link?

@fabulouiOS-monk
Copy link
Collaborator

@Mehul721 can you please share the PR link?

Got it!

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants