fix: update build for branch halo2-ecc-snark-verifier-0323
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhenfeizhang @lispc Try to update when trying to build on branch halo2-ecc-snark-verifier-0323. |
|
LGTM. Thanks! |
zhenfeizhang
added a commit
that referenced
this pull request
Mar 29, 2023
[feat] unit test for correct CircuitExt implementation [feat] api wrappers for SNARK's rust native verifier [feat] single layer testing with variant circuits Fix the build for branch `halo2-ecc-snark-verifier-0323`. (#3) [placeholer] impl CircuitExt for zkevm-circuits. [feat] testing scripts [feat] tests cases for the sdk [fix] use shplonk instead of gwc for aggregation
zhenfeizhang
added a commit
that referenced
this pull request
Apr 12, 2023
[chore] update cargo.toml [fix] use shplonk instead of gwc for aggregation [feat] tests cases for the sdk [feat] testing scripts [placeholer] impl CircuitExt for zkevm-circuits. Fix the build for branch `halo2-ecc-snark-verifier-0323`. (#3) [feat] single layer testing with variant circuits [feat] api wrappers for SNARK's rust native verifier [feat] unit test for correct CircuitExt implementation Implement `CircuitExt` for EVM circuits (#8) * Implement trait `CircuitExt` for zkevm circuits. * Add `EvmCircuit` test case. * add test script * [feat] expand circuit unit tests with aggregation and evm verification; two layers recursion unit test --------- Co-authored-by: Zhuo Zhang <[email protected]> Co-authored-by: zhenfei <[email protected]> [chore] update cargo lock Update Cargo.toml [revert] undo cargo fmt This reverts commit 77c9bd4. make zkevm-circuits dependency as dev dependency; get rid of jemalloc add default CircuitExt impl
zhenfeizhang
added a commit
that referenced
this pull request
Apr 12, 2023
[chore] update cargo.toml [fix] use shplonk instead of gwc for aggregation [feat] tests cases for the sdk [feat] testing scripts [placeholer] impl CircuitExt for zkevm-circuits. Fix the build for branch `halo2-ecc-snark-verifier-0323`. (#3) [feat] single layer testing with variant circuits [feat] api wrappers for SNARK's rust native verifier [feat] unit test for correct CircuitExt implementation Implement `CircuitExt` for EVM circuits (#8) * Implement trait `CircuitExt` for zkevm circuits. * Add `EvmCircuit` test case. * add test script * [feat] expand circuit unit tests with aggregation and evm verification; two layers recursion unit test --------- Co-authored-by: Zhuo Zhang <[email protected]> Co-authored-by: zhenfei <[email protected]> [chore] update cargo lock Update Cargo.toml [revert] undo cargo fmt This reverts commit 77c9bd4. make zkevm-circuits dependency as dev dependency; get rid of jemalloc add default CircuitExt impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nightly-2022-12-10as zkevm-circuits.axiom-crypto/halo2to branchaxiom/dev. Seems that there is no branchaxiom/faster-witness-generationin axiom-crypto/halo2.