Fix: cherry-pick pse pr#29 to let quotient has same number of chunk as it … #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z2trillion
pushed a commit
that referenced
this pull request
Jun 24, 2024
* chore: try pragma solidity 0.8.20 with CI * chore: make `transcript_initial_state` public So we can read transcript initial state from `VerifyingKey` * test: edit range_check example to trigger selector compression * [feat] add `aggregate_snarks` function (#34) * feat: add `aggregate_snarks` function - Previously you could only create a new `builder` pre-populated with the witnesses for snark aggregation. - This is a bad design pattern if you want to make a circuit that aggregates and also does other stuff. - This function will use whatever `SinglePhaseCoreManager` and `RangeChip` you provide to prove the snark aggregation. * chore: add comment * chore: fix comment * [feat(sdk)] `aggregate_snarks` returns loaded proof witnesses (#36) * feat(sdk): `aggregate_snarks` returns loaded proof witnesses * feat: add `TranscriptObject` to track assigned proof transcript * chore: Bump version to 0.1.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a cherry-pick of PR#29 from PSE's repo.
This pr fixed the mismatch issue of quotient polynomial's degree. As we know the quotient polynomial's degree is always of form
2^kin prover's side. The current code just use the max degree of custom gates / permutation / lookup. We should instead use(self.numerator.degree() - 1).next_power_of_two().