Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof integration fix store #1505

Open
wants to merge 2 commits into
base: proof-integration
Choose a base branch
from
Open

Proof integration fix store #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aff08a
using branch of sdk that passes to query stores with height-1 version…
eshelB Aug 8, 2023
7e746de
go.sum
eshelB Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.19
replace (
// dragonberry
github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0
github.com/cosmos/cosmos-sdk => github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230726163133-dc2b5eab1db5
github.com/cosmos/cosmos-sdk => github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230808154448-1e7ad22811a4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this scrtlabs/cosmos-sdk@1e7ad22811a4, is there a way to pass height-1 when we call this? I'm not sure what are the performance implications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we pass height-1 it breaks all other queries other than wasm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasm doesn't care as it has the cache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told Itzik about this, we thought maybe we should see what happens and if there are performance implications, we know what to look for. Also memory implications, as now queries have the whole db. But probably none of these implications exist as these are all pointers to subsections of the iavl store?

Copy link
Member

@toml01 toml01 Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we see performance issues, we could probably even create a context with both height and height - 1 instead of the whole store.

Copy link
Contributor Author

@eshelB eshelB Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find a way to do this but it seems that the multiStore there didn't support more than one specific version, only all of them

// last-marker-in-baseapp branch
// github.com/cosmos/cosmos-sdk => github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230409144936-ac748ac472c2
// Fix OSX Ledger Connection Issues - Premerged https://github.com/cosmos/ledger-cosmos-go/pull/36/files
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,8 @@ github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb
github.com/samuel/go-zookeeper v0.0.0-20190923202752-2cc03de413da/go.mod h1:gi+0XIa01GRL2eRQVjQkKGqKF3SF9vZR/HnPullcV2E=
github.com/sasha-s/go-deadlock v0.3.1 h1:sqv7fDNShgjcaxkO0JNcOAlr8B9+cV5Ey/OB71efZx0=
github.com/sasha-s/go-deadlock v0.3.1/go.mod h1:F73l+cr82YSh10GxyRI6qZiCgK64VaZjwesgfQ1/iLM=
github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230726163133-dc2b5eab1db5 h1:t0YeSrVF+jYgIidlWPyFwicTTJwmq815r3m5sx7jyAE=
github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230726163133-dc2b5eab1db5/go.mod h1:6n46SDUlhsl+a3+CaO1Xqb35CFxMqMdiouXnhZU2vvQ=
github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230808154448-1e7ad22811a4 h1:bqie3A5Czm7xUvYz4jRrla9Th+zCX8BaSSPyF1BOaqg=
github.com/scrtlabs/cosmos-sdk v0.45.13-0.20230808154448-1e7ad22811a4/go.mod h1:6n46SDUlhsl+a3+CaO1Xqb35CFxMqMdiouXnhZU2vvQ=
github.com/scrtlabs/tendermint v1.9.0-scrt h1:WohrW4d2lYVBWkYkv9QtPDG6CKOOaxSX5gtDQZ5oRVE=
github.com/scrtlabs/tendermint v1.9.0-scrt/go.mod h1:wBQs1xza37rbFHU1vFOWqc3dmcciGDHYLfzpoN5uqhw=
github.com/scrtlabs/tm-secret-enclave v1.9.6 h1:pTQpq1jEU/6m+jThuxl8RFggsG83qLPG/1R8TEI62AE=
Expand Down
Loading