Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract api-client main features behind a trait #267

Closed
clangenb opened this issue Aug 1, 2022 · 0 comments · Fixed by #363
Closed

Abstract api-client main features behind a trait #267

clangenb opened this issue Aug 1, 2022 · 0 comments · Fixed by #363
Assignees
Labels
F7-enhancement Enhances an already existing functionality Q3-substantial

Comments

@clangenb
Copy link
Collaborator

clangenb commented Aug 1, 2022

This would greatly simplify the separation between the core logic and the custom business logic in the integritee-worker in case the node has some customizations, which are incompatible with the default api-client type, e.g., the signed extra if pallet_asset_tx_payment is used.

Excerpt from the envisioned trait

pub trait Api {
          fn get_storage<V>() -> Result<Option<V>>;
     
          fn subscribe_events();

        // etc.
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F7-enhancement Enhances an already existing functionality Q3-substantial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants