Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make primitives generic over Index, Hash and Balance #334

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Make primitives generic over Index, Hash and Balance #334

merged 6 commits into from
Nov 21, 2022

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Nov 21, 2022 •
edited
Loading

  • ExtrinsicParams is now generic over Index and Hash and the Tips over the Balance. The most common types are still re-exported, but that does not make the primitives less generic. Therefore, I think this PR closes When can the fixme: make generic be done? #119
  • bump primitives crate to v0.2.1. (or should that rather be v0.3.0 @clangenb ?)

The Api and RpcClient are not yet generic. This will be done in a second step, ideally while implementing the Api Trait in #267

@haerdib haerdib self-assigned this Nov 21, 2022
@haerdib haerdib marked this pull request as ready for review November 21, 2022 10:35
@haerdib haerdib added the F7-enhancement Enhances an already existing functionality label Nov 21, 2022
echevrier
echevrier approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clangenb
clangenb approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@haerdib haerdib merged commit 7e328e0 into master Nov 21, 2022
@haerdib haerdib deleted the bh/generic-extrinsic-params branch November 21, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

@echevrier echevrier echevrier approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When can the fixme: make generic be done?
3 participants
@haerdib @clangenb @echevrier