Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to newest substrate commit to fix CI #519

Closed
haerdib opened this issue Apr 5, 2023 · 2 comments · Fixed by #524
Closed

Update to newest substrate commit to fix CI #519

haerdib opened this issue Apr 5, 2023 · 2 comments · Fixed by #524
Assignees
@haerdib
Labels
F2-bug Something isn't working F3-test fix tests or CI Z5-duplicate

Comments

@haerdib
Copy link
Contributor

haerdib commented Apr 5, 2023

There's been a breaking commit once again (CI does fail at get_payment_info test). I'm quite certain that the culprit is the following PR: https://github.com/paritytech/substrate/pull/13699/files
@haerdib haerdib changed the title Update to newest substrate commit Update to newest substrate commit to fix CI Apr 5, 2023
@haerdib
Copy link
Contributor Author

haerdib commented Apr 5, 2023

I'd not spend too much time on fixing the get_payment_info. If it's not easily fixable, we should remove them completely, as these are already decprecated rpc functions: https://polkadot.js.org/docs/substrate/rpc/#payment

@haerdib
Copy link
Contributor Author

haerdib commented Apr 6, 2023

Duplicate of #518

@haerdib haerdib marked this as a duplicate of #518 Apr 6, 2023
@haerdib haerdib self-assigned this Apr 11, 2023
@haerdib haerdib mentioned this issue Apr 11, 2023
Merged
@haerdib haerdib added F2-bug Something isn't working F3-test fix tests or CI labels Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F2-bug Something isn't working F3-test fix tests or CI Z5-duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Substrate commit 7363dce scs/substrate-api-client
1 participant
@haerdib