Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Substrate commit 7363dce #524

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Update to Substrate commit 7363dce #524

merged 6 commits into from
Apr 11, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Apr 11, 2023 •
edited
Loading

Cargo update of substrate and fix compiler errors:

  • run cargo update -p sp-core
  • re-copy paste client keystore to match new substrate version
  • update pallet contracts config

Fix pallet transaction payment:

  • add the new weight type of Substrate to serde_impls
  • update RuntimeDispatchInfo to use the new Weight type.

Fix license check:

fixes #519
fixes #518

@haerdib haerdib self-assigned this Apr 11, 2023
@haerdib haerdib added E1-breaksnothing F2-bug Something isn't working F3-test fix tests or CI labels Apr 11, 2023
@haerdib haerdib mentioned this pull request Apr 11, 2023
Closed
@haerdib haerdib marked this pull request as ready for review April 11, 2023 09:46
@haerdib haerdib changed the title Update RuntimeDispatchInfo to use new weight type Update to Substrate commit 7363dce Apr 11, 2023
Niederb
Niederb approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

echevrier
echevrier approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haerdib haerdib merged commit 1814c4c into master Apr 11, 2023
@haerdib haerdib deleted the bh/fix-ci branch April 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F2-bug Something isn't working F3-test fix tests or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to newest substrate commit to fix CI Integration test pallet_transaction_payment_tests failing
3 participants
@haerdib @Niederb @echevrier