Make Api no_std compatible
#377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
force-pushed
the
bh/make-api-no-std-compatible
branch
3 times, most recently
from
ee62727
to
175e991
Compare
This was referenced Dec 21, 2022
haerdib
force-pushed
the
bh/make-api-no-std-compatible
branch
from
a5210cd
to
e5b0b78
Compare
clangenb
reviewed
Dec 22, 2022
node-api/src/metadata.rs
Outdated
| use codec::{Decode, Encode, Error as CodecError}; | ||
| use frame_metadata::{ | ||
| PalletConstantMetadata, RuntimeMetadata, RuntimeMetadataLastVersion, RuntimeMetadataPrefixed, | ||
| StorageEntryMetadata, META_RESERVED, | ||
| }; | ||
| use scale_info::{form::PortableForm, PortableRegistry, Type}; | ||
| use sp_core::storage::StorageKey; | ||
|
|
||
| #[cfg(feature = "std")] | ||
| use serde::Serialize; | ||
|
|
||
| // We use `BTreeMap` because we can't use `HashMap` in `no_std`. |
There was a problem hiding this comment.
can you move this comment too?
Comment on lines
+29
to
+30
| + Serialize | ||
| + DeserializeOwned |
There was a problem hiding this comment.
Here we enforce something that is more than what the trait bounds in substrate guarantee Hence, we should maybe add a comment that those types need to re-implement serialization similar to how you re-implemented it for substrate types. What do you think?
Niederb
approved these changes
Dec 22, 2022
remove rpc crate dep always use alloc make api no-std compatible fix NumberOrHex update deps remove unused error make rpc open as well add postcard as Deserializer fix rpc params some further fixes amek rpc no-std compatible enfore Serialize and Deserialize instead of Maybe compile :) fix CI fix build fmt fix rebase errors add insert_with_allocation_test works fix no_std build more copy paste add no_std compatibility fix taplo remove sp_std cargo fmt remove extra space remove std feature obsolete remove obsolsete std feature remove unused comment Fix ci.yml (#389) * fix ci.yml * fix ci fmt impl serialize for NumberOrHex remove unnecessary redefined types extract serde impls from types and import whatever possible add from impls and tests add comment some more comments udpate comment add storage change set fix from serde impl fix build remove std only feature to subscription let it compile again :) fix tests remove some more std only feature make tx payment no_std compatible add extrinsic to no_std compatibility add balances extrinisc to no-std
haerdib
force-pushed
the
bh/make-api-no-std-compatible
branch
from
84a40e2
to
d03d7cd
Compare
clangenb
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 Featuring added
no_stdcompatibility for the fullApiincluded traits and the implementations (except for the rpc clients)sp-stddependency. Whenever possible, depend oncoreorallocdirectly. Thestdversion itself points to them as well. No need for an extra library to do that,primitives/serde_implsto implement serde also inno_std. Wherever sensible, the conversion from substrate type and redefined type has been implemented withFrom. So the newly self-implemented types should not pose a big problem for the user. Another good thing: If substrate updates the types, this will be noticed quite fast via the unit tests.MaybeSerializeDeserializebecause this only enforces (De)Serialization only instdmode.NumberOrHexbecausesp-rpcis notno_stdcompatible.src/api/error.rscloses #279