Function renamings in state api interface + improved documentation
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
reviewed
Feb 8, 2023
masapr
force-pushed
the
sp/412-cleanup-get-storage
branch
from
361b616
to
1e3d5be
Compare
masapr
added
F5-refactor
masapr
changed the title
state api + added comments
masapr
changed the title
state api + added commentsstate api interface + improved documentation
haerdib
reviewed
Feb 8, 2023
src/api/rpc_api/state.rs
Outdated
| /// Retrieve the raw storage for the given `storage_key`. | ||
| /// | ||
| /// `at_block`: the state is queried at this block, set to `None` to get the state from the latest known block. | ||
| fn get_opaque_storage( |
There was a problem hiding this comment.
Above, the _by_key is used whenever a storage key is required as an input. If there's no by_key, then the pallet and storage item are required. Is this convention break here intentional?
There was a problem hiding this comment.
Thanks for this observation. Will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@haerdib can you check if these are the renamings you had in mind in #412
closes #412