Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide get_account_nonce method #508

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Provide get_account_nonce method #508

merged 5 commits into from
Apr 3, 2023

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Apr 3, 2023 •
edited
Loading

Straightforward implementation. I thought it fits quite nicely with the GetAccountInformation trait

@Niederb Niederb changed the title Account getter helpers Provide get_nonce_of method Apr 3, 2023
@Niederb Niederb self-assigned this Apr 3, 2023
@Niederb Niederb added F8-newfeature Introduces a new feature E1-breaksnothing labels Apr 3, 2023
@Niederb Niederb marked this pull request as ready for review April 3, 2023 08:49
@Niederb Niederb changed the title Provide get_nonce_of method Provide get_account_nonce method Apr 3, 2023
@Niederb Niederb requested a review from haerdib April 3, 2023 09:19
@Niederb Niederb requested a review from echevrier April 3, 2023 13:02
echevrier
echevrier approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haerdib haerdib self-requested a review April 3, 2023 14:05
@Niederb Niederb merged commit 48ca6a3 into master Apr 3, 2023
@Niederb Niederb deleted the tn/account-getter-helpers branch April 5, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

@echevrier echevrier echevrier approved these changes

Assignees

@Niederb Niederb

Labels
E1-breaksnothing F8-newfeature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Niederb @haerdib @echevrier