Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate substrate types #580

Merged
merged 6 commits into from
Jun 8, 2023
Merged

Remove duplicate substrate types #580

merged 6 commits into from
Jun 8, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jun 7, 2023 •
edited
Loading

  • Removes duplicate substrate types, where possible. Removed types are now re-exported from substrate to avoid too many breaking changes.
  • cargo update

closes #391

@haerdib haerdib self-assigned this Jun 7, 2023
@haerdib haerdib marked this pull request as ready for review June 8, 2023 11:04
@haerdib haerdib requested review from Niederb and echevrier June 8, 2023 11:05
@Niederb
Copy link
Contributor

Niederb commented Jun 8, 2023

I already like it 😄
image

echevrier
echevrier approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Niederb
Niederb approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haerdib haerdib merged commit f11729e into master Jun 8, 2023
@haerdib haerdib deleted the bh/remove-duplicate-substrate-types branch June 8, 2023 12:34
@masapr masapr mentioned this pull request Jun 15, 2023
Closed
@haerdib haerdib mentioned this pull request Jun 29, 2023
Merged
clangenb added a commit that referenced this pull request Sep 14, 2023
@clangenb
Revert "Remove duplicate substrate types (#580)"
ea49a0d 
This reverts commit f11729e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ease of use of api client in no_std
3 participants
@haerdib @Niederb @echevrier