Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support metadata v15 #587

Merged
merged 5 commits into from
Jun 16, 2023
Merged

support metadata v15 #587

merged 5 commits into from
Jun 16, 2023

Conversation

masapr
Copy link
Collaborator

@masapr masapr commented Jun 14, 2023

Support metadata v15. Any metadata v14 is converted to v15.
closes #544

@masapr masapr self-assigned this Jun 14, 2023
@masapr masapr added F8-newfeature Introduces a new feature E1-breaksnothing F9-dependencies Pull requests that update a dependency file E2-breaksapi and removed E1-breaksnothing F8-newfeature Introduces a new feature labels Jun 14, 2023
@masapr masapr marked this pull request as ready for review June 14, 2023 13:04
@masapr masapr requested a review from haerdib June 14, 2023 13:05
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that was less painful than I thought it will be!

node-api/src/from_v14_to_v15.rs Show resolved Hide resolved
@@ -387,15 +390,16 @@ mod tests {
assert_eq!(actual_fields_no_context, expected.fields);
}

#[test]
fn dynamically_decode_single_event() {
#[test_case(SupportedMetadataVersions::V14)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ❤️

@masapr masapr requested a review from haerdib June 15, 2023 07:39
@masapr masapr merged commit 5325827 into master Jun 16, 2023
@haerdib haerdib deleted the sp/support-metadata-v15 branch February 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2-breaksapi F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support metadata V15
2 participants