-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support metadata v15 #587
Merged
Merged
support metadata v15 #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y still uses v14 for both cases)
file from_v14_to_v15.rs contains a function copied from subxt: https://github.com/paritytech/subxt/blob/b9f5419095b31b64421fef1edea6facea607c915/metadata/src/from_into/v14.rs
masapr
added
F8-newfeature
Introduces a new feature
E1-breaksnothing
F9-dependencies
Pull requests that update a dependency file
E2-breaksapi
and removed
E1-breaksnothing
F8-newfeature
Introduces a new feature
labels
Jun 14, 2023
masapr
force-pushed
the
sp/support-metadata-v15
branch
from
June 14, 2023 13:05
e202762
to
edbd717
Compare
haerdib
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, that was less painful than I thought it will be!
@@ -387,15 +390,16 @@ mod tests { | |||
assert_eq!(actual_fields_no_context, expected.fields); | |||
} | |||
|
|||
#[test] | |||
fn dynamically_decode_single_event() { | |||
#[test_case(SupportedMetadataVersions::V14)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! ❤️
haerdib
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support metadata v15. Any metadata v14 is converted to v15.
closes #544