Fix comments of default Configs #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echevrier
requested changes
Jul 10, 2023
| @@ -15,7 +15,7 @@ use crate::{ | |||
| use codec::{Decode, Encode}; | |||
| use core::fmt::Debug; | |||
|
|
|||
| /// Default set of commonly used types by Substrate kitchensink runtime. | |||
| /// Commonly used config of Substrate runtimes that use the asset pallet. | |||
There was a problem hiding this comment.
Maybe "Standard runtime config for Substrate and Polkadot nodes that use the asset pallet" ?
| @@ -11,7 +11,7 @@ use crate::{ | |||
| config::WithExtrinsicParams, AssetRuntimeConfig, Config, GenericExtrinsicParams, PlainTip, | |||
| }; | |||
|
|
|||
| /// Default set of commonly used types by Polkadot nodes. | |||
| /// Commonly used config of Substrate and Polkadot nodes. | |||
| pub type DefaultRuntimeConfig = | |||
There was a problem hiding this comment.
Similar to previous comment: "Standard runtime config for Substrate and Polkadot nodes that use native payment" ?
There was a problem hiding this comment.
I'd refrain from using native payment, as Parity does not use it either.
What about a simple /// Standard runtime config for Substrate and Polkadot nodes. ?
echevrier
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.