Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata #734

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Update metadata #734

merged 5 commits into from
Feb 27, 2024

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 26, 2024 •
edited
Loading

closes #688

@haerdib haerdib self-assigned this Feb 26, 2024
@haerdib haerdib marked this pull request as ready for review February 26, 2024 12:43
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Feb 26, 2024
@haerdib haerdib requested a review from masapr February 26, 2024 12:43
masapr
masapr approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit a1775ad into master Feb 27, 2024
58 of 59 checks passed
@haerdib haerdib deleted the bh/update-metadata branch February 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update node-api parts
2 participants
@haerdib @masapr