Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename node-template-runtime dependency #751

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Rename node-template-runtime dependency #751

merged 2 commits into from
Mar 14, 2024

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Mar 12, 2024 •
edited
Loading

Currently our dependencies are broken on master. For example cargo update fails with:

    Updating crates.io index
    Updating git repository `https://github.com/paritytech/polkadot-sdk.git`
error: no matching package named `node-template-runtime` found
location searched: https://github.com/paritytech/polkadot-sdk.git?branch=master
required by package `ac-primitives v0.9.1 (/home/tniederberger/repos/substrate-api-client/primitives)`

Apparently the node-template-runtime dependency has been renamed to solochain-template-runtime. See this PR: paritytech/polkadot-sdk#3460
and especially this line https://github.com/paritytech/polkadot-sdk/blob/4c810609d6c72b48bd748398165da5c27a604778/prdoc/pr_3460.prdoc#L24

Additionaly it seems that SignedExtra has been renamed to TxExtension. See paritytech/polkadot-sdk#2280

@Niederb Niederb changed the title Change dependency from node-template-runtime to solochain-template-ru… Rename node-template-runtime dependency Mar 12, 2024
@Niederb Niederb added E1-breaksnothing F9-dependencies Pull requests that update a dependency file labels Mar 12, 2024
@Niederb Niederb force-pushed the tn/rename-node-template-runtime branch from d472a70 to b4cdaa5 Compare March 13, 2024 09:47
@Niederb Niederb marked this pull request as ready for review March 13, 2024 09:48
@Niederb Niederb requested a review from masapr March 13, 2024 10:26
masapr
masapr approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Niederb Niederb merged commit cc4a4a4 into master Mar 14, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing F9-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niederb @masapr