Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"appName" URI option is overriden by hardcoded "akka-persistence-mongodb" application name #407

Closed
fguerout opened this issue Dec 18, 2020 · 3 comments
Labels

Comments

@fguerout
Copy link

Hi,

Thx for great library!

"appName" URI option (https://docs.mongodb.com/manual/reference/connection-string/#urioption.appName) is overriden by hardcoded "akka-persistence-mongodb" application name in scala driver: https://github.com/scullxbones/akka-persistence-mongo/blob/master/scala/src/main/scala/akka/contrib/persistence/mongodb/ScalaDriverPersistenceExtension.scala#L28

Should we default to "akka-persistence-mongodb" but keep "appName" option safe in URI ?

Thx in advance,
Br,

@scullxbones
Copy link
Owner

@fguerout - if you can open a PR with that commit i'll get it released.

Can you give any more details on this, specifically on "header not correctly read":

I've tried to switch to rxmongo instead (which does not have this issue) but I'm facing another issue with snapshot replay (header is not correctly read)

Would like to get an issue tracking that problem, the drivers should be interchangeable from the plugin's perspective.

@fguerout
Copy link
Author

fguerout commented Jan 5, 2021

@scullxbones - thx, just created #409

Regarding decoding issue (header not correctly read), I'll isolate it in a simple example project, and I'll share it with you.

@scullxbones
Copy link
Owner

Released with 3.0.6

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants