(fix): test for float32 and float64

scverse · Nov 11, 2024 · 150d8aa · 150d8aa
1 parent 98f7bea
commit 150d8aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/anndata/_core/index.py b/src/anndata/_core/index.py
@@ -82,7 +82,9 @@ def name_idx(i):
             indexer = np.array(indexer)
             if len(indexer) == 0:
                 indexer = indexer.astype(int)
-        if isinstance(indexer, np.ndarray) and indexer.dtype == float:
+        if isinstance(indexer, np.ndarray) and np.issubdtype(
+            indexer.dtype, np.floating
+        ):
             indexer_int = indexer.astype(int)
             if np.all((indexer - indexer_int) != 0):
                 raise IndexError(f"Indexer {indexer!r} has floating point values.")

diff --git a/tests/test_views.py b/tests/test_views.py
@@ -818,8 +818,11 @@ def test_index_3d_errors(index: tuple[int | EllipsisType, ...], expected_error:
     "index",
     [
         pytest.param(sparse.csr_matrix(np.random.random((1, 10))), id="sparse"),
-        pytest.param(np.array([1.2, 2.3]), id="ndarray"),
         pytest.param([1.2, 3.4], id="list"),
+        *(
+            pytest.param(np.array([1.2, 2.3], dtype=dtype), id=f"ndarray-{dtype}")
+            for dtype in [np.float32, np.float64]
+        ),
     ],
 )
 def test_index_float_sequence_raises_error(index):