-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view behavior for AwkwardArrays #1070
Open
grst
wants to merge
12
commits into
main
Choose a base branch
from
ak-array-views
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b23eda3 - Browse repository at this point
Copy the full SHA b23eda3View commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b640617 - Browse repository at this point
Copy the full SHA b640617View commit details -
Co-authored-by: Angus Hollands <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 843833f - Browse repository at this point
Copy the full SHA 843833fView commit details
Commits on Aug 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8aa09cc - Browse repository at this point
Copy the full SHA 8aa09ccView commit details
Commits on Sep 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 86c5ff8 - Browse repository at this point
Copy the full SHA 86c5ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a01b80e - Browse repository at this point
Copy the full SHA a01b80eView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for dfe7008 - Browse repository at this point
Copy the full SHA dfe7008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b14e57 - Browse repository at this point
Copy the full SHA 8b14e57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4870553 - Browse repository at this point
Copy the full SHA 4870553View commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 257c063 - Browse repository at this point
Copy the full SHA 257c063View commit details
Commits on Sep 8, 2023
-
The test didn't catch that when modifying an awkward array in a AnnDataView, the changes did not persist within that view. The issue was that I had been retreiving the awkward array from the view once, and then did tests on it. Instead, to properly test this, I need to retreive the Awkward array from the AnnData view every time. It turns out doing so gives me a fresh copy of the origina awkward array and modifications only affect that copy - not the original data.
Configuration menu - View commit details
-
Copy full SHA for 4b34598 - Browse repository at this point
Copy the full SHA 4b34598View commit details -
Fix that awkward arrays in an awyward array view could not be modified.
I solved the issue described in the previous commit by adding logic to `AlignedViewMixin` that can copy objects of a certain type (for now only awkward arrays) upon view creation.
Configuration menu - View commit details
-
Copy full SHA for fdeff90 - Browse repository at this point
Copy the full SHA fdeff90View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.