-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalize spec #882
Merged
Merged
Formalize spec #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 83.64% 83.70% +0.06%
==========================================
Files 34 34
Lines 4487 4498 +11
==========================================
+ Hits 3753 3765 +12
+ Misses 734 733 -1
|
will-moore
reviewed
Jan 23, 2023
giovp
requested changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly typos
Co-authored-by: Giovanni Palla <[email protected]>
lazappi
reviewed
Jan 25, 2023
ivirshup
commented
Jan 25, 2023
ivirshup
commented
Jan 25, 2023
ivirshup
added a commit
that referenced
this pull request
Jan 30, 2023
Added release note for #882, and used the user tag for PR authors
Merged
ivirshup
added a commit
that referenced
this pull request
Jan 30, 2023
* Update release notes Added release note for #882, and used the user tag for PR authors * typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding formal language and more details to the on disk specification for anndata.
The goal of this PR is to be more clear about what we expect to see from an AnnData formatted object on disk.
Eventually it would make sense to add some formatting to allow multiple versions of specifications, and to potentially separate prose and spec to separate documents.
TODO