Go back to regular pip

[flying-sheep]

Hahaha and of course after weeks of this bug, everything gets resolved the day I press the merge button. pypa/flit#395 should fix the issues where

1. pip install scvelo downgrades a flit install -s installed scanpy (now the dist-info dir name contains the correct version)
2. The wheel built by flit now corresponds to the freshly-changed spec’s mangling rules

So we can remove the workarounds. No problem, git blame won’t be affected much, this almost exclusively deletes lines.

[flying-sheep]

Just checked using this dockerfile, works flawlessly:

FROM continuumio/miniconda

RUN conda install python=3.8
RUN pip install flit>=3.1
RUN git clone https://github.com/theislab/scanpy.git
WORKDIR /scanpy
# Go to the mainline-pip branch if it hasn’t been merged into master yet
RUN git checkout mainline-pip || true
RUN FLIT_ROOT_INSTALL=1 flit install -s --dep=develop  # Make development install of scanpy
# Make sure the dist-info folder has a plus in its name
RUN SCANPY_VERSION=$(python -c 'from importlib.metadata import version; print(version("scanpy"))') && \
    echo $SCANPY_VERSION | grep '+' &&
    test -d /opt/conda/lib/python3.8/site-packages/scanpy-$SCANPY_VERSION.dist-info
# Install project that depends on scanpy
RUN pip install scvelo
# Make sure it’s still a dev install
RUN test -L /opt/conda/lib/python3.8/site-packages/scanpy

[ivirshup]

More something that should have been caught in previous review, for the Check Build job:

• Flit should be installed with the rest of the dependencies.
• Can some of those tools be removed? For example: setuptools.