Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test full Dask support for log1p, normalize_per_cell, filter_cells/filter_genes #2814

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jan 16, 2024

  • Release notes not necessary because: only dev changes

this tests that log1p, normalize_per_cell, filter_cells, and filter_genes return dask arrays when handed dask arrays.

@flying-sheep flying-sheep marked this pull request as draft January 16, 2024 11:44
@flying-sheep flying-sheep mentioned this pull request Jan 16, 2024
18 tasks
@flying-sheep flying-sheep added this to the 1.10.0 milestone Jan 16, 2024
@flying-sheep flying-sheep changed the title Full Dask support for filter_cells/filter_genes Full Dask support for log1p, normalize_per_cell, filter_cells/filter_genes Jan 16, 2024
@flying-sheep flying-sheep changed the title Full Dask support for log1p, normalize_per_cell, filter_cells/filter_genes Test full Dask support for log1p, normalize_per_cell, filter_cells/filter_genes Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4f4b1c3) 72.70% compared to head (b4a913d) 72.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   72.70%   72.72%   +0.01%     
==========================================
  Files         111      111              
  Lines       12368    12384      +16     
==========================================
+ Hits         8992     9006      +14     
- Misses       3376     3378       +2     
Files Coverage Δ
scanpy/_compat.py 50.00% <100.00%> (+5.55%) ⬆️
scanpy/preprocessing/_simple.py 83.13% <80.00%> (ø)
scanpy/preprocessing/_distributed.py 82.60% <80.00%> (-0.73%) ⬇️

@flying-sheep flying-sheep marked this pull request as ready for review January 16, 2024 15:33
@flying-sheep flying-sheep merged commit e00932b into master Jan 16, 2024
18 of 21 checks passed
@flying-sheep flying-sheep deleted the dask-filter branch January 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test full dask support for log1p, normalize_per_cell, filter_cells/filter_genes
1 participant