Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scRNA tutorial #159

Merged
merged 20 commits into from
Aug 9, 2024
Merged

Update scRNA tutorial #159

merged 20 commits into from
Aug 9, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented May 2, 2024

Fixes #153

basic clustering tutorial notebook

  • Seems like the manual annotation is already broken, so I removed it.
    If you have an idea how we can keep it stable, we could do that instead, but I couldn’t figure out which cluster assignments actually work.
  • Since {eval}thing does not work with nb_execution_mode == 'off' executablebooks/MyST-NB#596 hasn’t been merged for ages, I’m installing it from git for now. It’s a good way to reference not-too-stable numbers from text without having to manually keep an eye on things

Other notebooks

Conda setup

Some of the conda setup does no longer work, namely use-only-tar-bz2, so I needed to disable it. Let’s fully fix the setup in another PR, this PR makes it work again which was hard enough.

We should probably go away from conda in the first place. Installing pip packages into a conda environment is an undefined operation, all version bounds for the conda packages become meaningless when doing that. uv could be enough, otherwise we could go pixi or so.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@flying-sheep flying-sheep marked this pull request as ready for review August 6, 2024 11:24
@flying-sheep flying-sheep requested a review from grst August 6, 2024 11:26
@grst
Copy link
Collaborator

grst commented Aug 8, 2024

Seems like the manual annotation is already broken, so I removed it.
If you have an idea how we can keep it stable, we could do that instead, but I couldn’t figure out which cluster assignments actually work.

In scverse/scanpy#2014, we figured out that setting

export NUMBA_CPU_NAME=generic

makes the clustering results more stable (at least in the conditions I tested there) by only relying on basic CPU features. Would still need to redo it once but then hopefully it wouldn't change anymore in the future.

Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for suffering for us!

I would be in favor of giving it a shot to try out the reproducible clustering with the numba variable as manual clustering is still a commonly used approach.

docs/patched-deps.txt Show resolved Hide resolved
@grst
Copy link
Collaborator

grst commented Aug 8, 2024

And not sure why we went with conda in the first place, maybe because of compatibility with mybinder?

@flying-sheep
Copy link
Member Author

flying-sheep commented Aug 9, 2024

let’s restore the manual clustering in another PR, I don’t feel like going through all clusters and assigning labels manually.

@flying-sheep flying-sheep merged commit d63a32b into main Aug 9, 2024
2 checks passed
@flying-sheep flying-sheep deleted the update-scrna-scanpy branch August 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update basic clustering tutorial to be in sync with scanpy 1.10
2 participants