Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch creation to match new gocql #35

Merged
merged 1 commit into from
May 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modes.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ func DoBatchedWrites(session *gocql.Session, resultChannel chan Result, workload
request := fmt.Sprintf("INSERT INTO %s.%s (pk, ck, v) VALUES (?, ?, ?)", keyspaceName, tableName)

RunTest(resultChannel, workload, rateLimiter, func(rb *ResultBuilder) (error, time.Duration) {
batch := gocql.NewBatch(gocql.UnloggedBatch)
batch := session.NewBatch(gocql.UnloggedBatch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the old function should really be removed but upstream gocql doesn't really do semver so it is hard.

batchSize := 0

currentPk := workload.NextPartitionKey()
Expand Down