Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database_query_utils): make PartitionRowsValidationEvent contains diff between before and after state #8774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 19, 2024

When there is difference test ends with following message:

sdcm.sct_events.events_analyzer.TestFailure: Got critical event: (PartitionRowsValidationEvent Severity.CRITICAL) period_type=one-time event_id=318ca98d-c349-4cad-bddc-889918d9f326: message=Row amount in partitions is not same before and after running of nemesis: {0: 5555, 2: 5555, 5: 5555, 7: 5555, 8: 5555, 11: 5555, 12: 5555, 13: 5555, 14: 5555, ....}

Which does not tell you what is the difference.

Testing

Not tested

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@dkropachev dkropachev added the backport/none Backport is not required label Sep 19, 2024
yarongilor
yarongilor previously approved these changes Sep 19, 2024
Copy link
Contributor

@yarongilor yarongilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yarongilor
Copy link
Contributor

Should fix commit message.

@fruch
Copy link
Contributor

fruch commented Sep 19, 2024

@dkropachev

pre-commit compliens on length of lines in commit message

also do we have some run with it ? with some example of the output now ?

@dkropachev dkropachev force-pushed the dk-make-validate_rows_per_partitions-show-before branch from 4342c03 to 17a1371 Compare September 19, 2024 14:10
@dkropachev dkropachev force-pushed the dk-make-validate_rows_per_partitions-show-before branch from 17a1371 to acfe310 Compare September 27, 2024 19:19
diff between before and after state

When there is difference test ends with a message that does not tell you what is the difference.
@dkropachev dkropachev force-pushed the dk-make-validate_rows_per_partitions-show-before branch from acfe310 to d4d8386 Compare September 29, 2024 14:04
@fruch
Copy link
Contributor

fruch commented Nov 12, 2024

@dkropachev @yarongilor

can we have a run of it, to validate it's working as expected ?

also, we need to fix the commit message commitlint doesn't agree with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants