[BREAKING] Remove parametric modeling code #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #334.
This doesn't make NAM incompatible with parametric modeling. It just moves the implementation downstream, with the intent that users would register their implementations using
Model.register_net_initializer()andnam.data.register_dataset_initializer(). If you like the code I wrote, you should be able to re-register it with little trouble and continue on as you were.This also results in some nice simplifications like the removal of the separate "export" script since all models are assumed to be compatible with the
Exportable.export()interface. Now, you get the.nammodel at the end of CLI training immediately without a separate step 🙂 (parametric modeling folks will need to make changes here to pull in the extra needed configuration info at the time of the model's initialization so that it can be accessed here since it's no longer an input argument to the export method.)