This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
Introduce strategic prefetching #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These expose a single method for ensuring that all necessary network activity gets done. Basically, this makes prefetching a lot simpler.
There are two, somewhat-overlapping goals here: 1. Don't initiate network activity, even in the background, unless we're pretty sure we're going to need the results of that work. 2. Don't initiate background network activity unless we're pretty sure it will result in beneficial parallelism. Basically, we want to avoid network activity if we can. If we're likely to need it, though, then to avoid complexity growth owing to doing a ton of background work (which entails synchronization), we do async prefetching only if we have a strong reason to believe it will result in parallelism.
Current coverage is 71.46% (diff: 71.42%)@@ master #85 diff @@
==========================================
Files 22 22
Lines 3130 3171 +41
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2223 2266 +43
- Misses 698 706 +8
+ Partials 209 199 -10
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13