Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy and fix issues #680

Merged
merged 12 commits into from
Jun 10, 2023

Conversation

bryanforbes
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This upgrades mypy to 0.991 and fixes the errors associated with it. I've also removed the mypy check from pre-commit and added a type checking step during unit testing. This requires running poetry install twice to remove the type checking dependencies to ensure that there are no runtime dependencies on the type checking libraries (like typing_extensions). Another option would be to change the pre-commit config to use mypy via poetry, remove the third-party pre-commit PR hook, and add a Github action that invokes pre-commit with the proper poetry install. That can be done as a separate PR, though.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2023

CodSpeed Performance Report

Merging #680 feature/mypy-improvement (681be2d) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 2 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@bryanforbes bryanforbes mentioned this pull request Mar 8, 2023
2 tasks
@Secrus Secrus mentioned this pull request May 10, 2023
2 tasks
@Secrus
Copy link
Collaborator

Secrus commented May 24, 2023

@bryanforbes could you update to the latest version of mypy and fix potential issues? I will have some time this weekend and want to merge this.

@bryanforbes
Copy link
Contributor Author

@Secrus this is ready to go

@Secrus Secrus merged commit 5bc805c into sdispater:master Jun 10, 2023
@bryanforbes bryanforbes deleted the feature/mypy-improvement branch October 13, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants