Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less 3.8 #14

Merged
merged 26 commits into from
Feb 26, 2019
Merged

Less 3.8 #14

merged 26 commits into from
Feb 26, 2019

Commits on Dec 6, 2018

  1. package – update css-compile script to use --math

    --strict-math has been deprecated and replaced by --math.  See less/less.js#3274
    calvinjuarez committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    c12f2be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    828ad7e View commit details
    Browse the repository at this point in the history
  3. each – use each() for loops (WIP)

    Still haven't updated for the grid breakpoints just yet, though some breakpoint loops have been written in anticipation of those updates.
    calvinjuarez committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    fb6c4e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3819dc View commit details
    Browse the repository at this point in the history
  5. each – replace all #each-* loop with each or #for-*

    There are 4 loops in mixins/_grid-framework.less that loop 'til a static number.  I'm not aware of any answer for that at the moment, but a plugin could be easily written that could just leverage `each()`.
    calvinjuarez committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    512b7f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Configuration menu
    Copy the full SHA
    b565efa View commit details
    Browse the repository at this point in the history
  2. plugins – fix lint warnings/errors

    Except one in breakpoints.js:
    
    ```
    91:6   warning  Variable 'nextBreakpoint' should be initialized on declaration
    ```
    calvinjuarez committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    b801400 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd68b7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94a03d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2018

  1. README – update to match true min version required

    Co-Authored-By: calvinjuarez <[email protected]>
    seanCodes and calvinjuarez authored Dec 16, 2018
    Configuration menu
    Copy the full SHA
    787c6b4 View commit details
    Browse the repository at this point in the history
  2. plugins/theme-color-level – more readable code

    Co-Authored-By: calvinjuarez <[email protected]>
    seanCodes and calvinjuarez authored Dec 16, 2018
    Configuration menu
    Copy the full SHA
    085e7b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c41f725 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95c71c3 View commit details
    Browse the repository at this point in the history
  5. README – wording edits

    Co-Authored-By: calvinjuarez <[email protected]>
    seanCodes and calvinjuarez authored Dec 16, 2018
    Configuration menu
    Copy the full SHA
    19f2b6f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0bf3c70 View commit details
    Browse the repository at this point in the history
  7. README – more wording edits

    Co-Authored-By: calvinjuarez <[email protected]>
    seanCodes and calvinjuarez authored Dec 16, 2018
    Configuration menu
    Copy the full SHA
    942a7bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d888c5e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1c4f82b View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. rename plugin keysmap-keys

    Reverting the name change for now, until @calvinjuarez is able to pull
    in the plugin from NPM and alias it. (See [his
    comment](seanCodes#14 (comment)
    sion_r241965904).)
    
    This change addresses [this PR review
    comment](seanCodes#14 (comment)
    sion_r239916331).
    seanCodes committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    9c63386 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. _grid-framework – revert loop renaming

    Reduce the number of changes in the PR to avoid potential bugs.
    
    This change addresses [this PR review comment](seanCodes#14 (comment)).
    seanCodes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    68f97a4 View commit details
    Browse the repository at this point in the history
  2. _transition – revert var renaming

    Match var names used in the Sass version of the mixin.
    
    This change addresses [this PR review comment](seanCodes#14 (comment)).
    seanCodes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    8a300b6 View commit details
    Browse the repository at this point in the history
  3. breakpoints – put long comments on own line

    (instead of including at the end of a line)
    seanCodes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    2bf786a View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. restore color-function plugins

    Revert deletion of plugin files that add the `color()`, `gray()` and
    `theme-color()` functions. Even though Less’ new ruleset accessors could
    be used, we’re going to keep them for parity with the Sass version and
    for backwards compatibility.
    
    This change addresses [this PR review comment](seanCodes#14).
    seanCodes committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    6917d55 View commit details
    Browse the repository at this point in the history
  2. restore usages of color functions

    Revert the conversion the `color()`, `gray()` and `theme-color()`
    functions to Less’ ruleset accessors. This change is primarily being
    made to keep the syntax as similar to the Sass version as possible, for
    easy reference/comparison.
    
    Note that keeping things similar to Sass may prove unnecessary in the
    future, so we may go back to accessors, but for now we’ll keep it like
    this.
    
    This change addresses [this PR review comment](seanCodes#14).
    seanCodes committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    d2d9ef9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    33642be View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. fix bug in ruleset-to-map conversion

    Instead of pulling the `value` directly from each item in the ruleset,
    evaluate the item first to determine the true value of the item. This
    fixes the issue where the `value` is actually a var name and what we
    want is the the value of the var—not the var name itself.
    seanCodes committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    d65fa87 View commit details
    Browse the repository at this point in the history