Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drastically improving throughput on larger inputs (3x+ for large URIs or header-values)
There are 2 optimizations in this PR:
We don't need to
or
the upper half of the register withxFF
we can instead compute trailing-zeros on the meaningful bits by usingeax
(u32
) instead ofrax
(u64
) andax
(u16
) instead ofeax
(u32
) for AVX2 and SSE4.2 respectively.target_feature
pragmas to allow SIMD validators to be inlined, so when looped we benefit from greater register reuse etc... See:Benchmarks
Summary table
(Disclaimer: aggregated by ChatGPT, which "computed" the ratio rows which aren't exactly correct but close enough)
Raw benches