Add public interface to Multipart's Part headers
#1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanmonstar is this project open to PRs? |
|
Yes it is, sorry, got lost in a short week. |
|
Oh no worries! Let me know if anything needs to be changed in this proposal EDIT : looks like a missed a |
|
The CI failures seem unrelated to the code itself |
|
@seanmonstar hope you had a good holiday season and started the new year well! I have merged master into my branch so hopefully everything should be green on the CI side now. Best |
seanmonstar
reviewed
Jan 3, 2023
beeb
commented
Jan 3, 2023
| use mime_guess::Mime; | ||
| use percent_encoding::{self, AsciiSet, NON_ALPHANUMERIC}; | ||
|
|
||
| use futures_core::Stream; | ||
| use futures_util::{future, stream, StreamExt}; | ||
|
|
||
| use super::Body; | ||
| use crate::header::HeaderMap; |
There was a problem hiding this comment.
I thought this made sense since the request.rs also uses the re-exported HeaderMap
seanmonstar
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application where I'd like to add compressed files to a multipart form request, and would like to set the
content-encodingheader for said files in the request. However, the current implementation doesn't allow editing the metadata onmultipart::Parts. I added the necessary public setters to be able to to add custom headers to the multipart items.