-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unmaintained/outdated github actions #1020
Conversation
The toolchain is now installed with `dtolnay/rust-toolchain`.
Hi, and thanks for this! |
I think we can solve this by changing the types to |
This fixes the new compiler warning about implicit associated type bounds, as per seanmonstar#1020 (comment)
1. Don't take references of Strings unless their needed. 2. Use explicit tuple with Extract = impl Reply type, as per seanmonstar/warp#1020 (comment), to avoid warnings about implicit attributed bounds.
This indeed makes the warp examples compile. Any plans to merge these modifications? |
would you like to submit a PR addressing that? :) |
- Per Sean McArthur's suggestion here - seanmonstar#1020 (comment) - Fixes seanmonstar#1015
- Per Sean McArthur's suggestion here - seanmonstar#1020 (comment) - Fixes seanmonstar#1015
- Per Sean McArthur's suggestion here - #1020 (comment) - Fixes #1015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The toolchain is now installed with
dtolnay/rust-toolchain
.