Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework sse filter #663

Merged
merged 6 commits into from
Jan 12, 2021
Merged

rework sse filter #663

merged 6 commits into from
Jan 12, 2021

Conversation

jxs
Copy link
Collaborator

@jxs jxs commented Jul 21, 2020 •
edited
Loading

closes #645

@jxs jxs requested a review from seanmonstar July 21, 2020 00:14
seanmonstar
seanmonstar reviewed Jul 22, 2020
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the direction I meant, great work!

src/filters/sse.rs Outdated Show resolved Hide resolved
src/filters/sse.rs Outdated Show resolved Hide resolved
@jxs jxs changed the title rework sse filter, closes #645 rework sse filter Jul 29, 2020
@jxs jxs requested a review from seanmonstar July 29, 2020 09:41
@jxs jxs mentioned this pull request Aug 6, 2020
Merged
@xla
Copy link
Contributor

xla commented Oct 15, 2020

Could this get merged? It would improve the usability of the module immensely.

@seanmonstar seanmonstar mentioned this pull request Nov 30, 2020
Closed
xla
xla reviewed Dec 12, 2020
View reviewed changes
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks very good!

src/filters/sse.rs Show resolved Hide resolved
src/filters/sse.rs Show resolved Hide resolved
@allenap allenap mentioned this pull request Jan 1, 2021
Closed
4 tasks
seanmonstar
seanmonstar reviewed Jan 4, 2021
View reviewed changes
src/filters/sse.rs Outdated Show resolved Hide resolved
src/filters/sse.rs Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit c8964b1 into seanmonstar:master Jan 12, 2021
@jxs jxs deleted the rework-sse branch January 12, 2021 08:27
@jxs jxs mentioned this pull request Feb 21, 2021
Closed
jxs added a commit to jxs/warp that referenced this pull request Jun 27, 2021
@jxs
rework sse filter (seanmonstar#663)
420c197 
closes seanmonstar#645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xla xla xla left review comments

@jhpratt jhpratt jhpratt left review comments

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change SSE module to be more like WS
4 participants
@jxs @xla @seanmonstar @jhpratt