Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redirect::AsLocation public #701

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

haileys
Copy link
Contributor

@haileys haileys commented Aug 30, 2020

This enables documentation while still keeping the trait sealed outside of the redirect mod. Here's what the docs now look like:

screen_shot_2020_08_30_at_16 07 01-8922e96c0e046c

screen_shot_2020_08_30_at_16 07 08-263caea19cfdda

Charlie Somerville and others added 2 commits August 30, 2020 16:01
The Sealed trait it inherits from is still private to this mod, so users
are still unable to impl AsLocation for other types, but can now see
documentation for the AsLocation trait and its implementors
@jxs jxs merged commit bd59169 into seanmonstar:master Jun 8, 2021
@jxs
Copy link
Collaborator

jxs commented Jun 8, 2021

Hi and thanks for the PR! Even the trait keeps sealed for implementation it's now open to use on type's and function signatures, thou I think it's ok in this case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants