Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tracing/log feature #861

Merged
merged 2 commits into from
Jun 5, 2021

Conversation

johannescpk
Copy link
Contributor

log::Record's are !Send + !Sync and tracing's log feature automatically uses those, which can be problematic for consumers. Exposing the feature allows consumers to not enable the log feature.

The feature is called trace-log since both log and tracing-log are blocked by crates with the same name.

@jxs jxs merged commit ab31398 into seanmonstar:master Jun 5, 2021
@jxs
Copy link
Collaborator

jxs commented Jun 5, 2021

Hi, yeah this makes sense, hyper did the same.
Thanks!

@johannescpk johannescpk deleted the feat/expose-tracing-log branch June 5, 2021 17:31
seanmonstar added a commit that referenced this pull request Nov 4, 2021
seanmonstar added a commit that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants