fix: 🐛 check if schema exists now works as intended

Check if schema exists now checks if id is part of the name. Removed zod
to avro implementation that was only used in testing.

.changeset/wicked-ligers-hope.md

@@ -0,0 +1,5 @@
+---
+"@sebspark/pubsub": minor
+---
+
+Fixes bug that did not check if a schema exists in the correct way.

packages/pubsub/package.json

@@ -24,9 +24,7 @@
     "@types/html-escaper": "3.0.2",
     "avsc": "^5.7.7",
     "express": "4.21.0",
-    "html-escaper": "3.0.3",
-    "ts-pattern": "^5.5.0",
-    "zod": "^3.23.8"
+    "html-escaper": "3.0.3"
   },
   "keywords": [
     "google apis",

packages/pubsub/src/lib/publisher.spec.ts

@@ -6,20 +6,35 @@ import {
 } from '@google-cloud/pubsub'
 import { Type } from 'avsc'
 import { type Mock, type MockedObject, describe, expect, it, vi } from 'vitest'
-import { z } from 'zod'
 import { createPublisher } from './publisher'
-import { zodToAvro } from './zod-to-avro'
 
-const exampleSchema = z.object({
-  messageType: z.string(),
-  created: z.string(),
-  data: z.string().optional(),
-})
+type ExampleMessage = {
+  messageType: string
+  message: string
+}
 
-type ExampleMessage = z.infer<typeof exampleSchema>
-const exampleAvroSchema = zodToAvro('Example', exampleSchema, {
-  namespace: 'com.acme.example',
-})
+const exampleAvroSchema = `
+{
+  "type": "record",
+  "name": "ExampleMessage",
+  "namespace": "com.example",
+  "fields": [
+    {
+      "name": "messageType",
+      "type": "string"
+    },
+    {
+      "name": "message",
+      "type": "string"
+    }
+  ]
+}
+`
+
+const message = {
+  messageType: 'type of message',
+  message: 'message data',
+} satisfies ExampleMessage
 
 type ExamplePubsubChannels = {
   example: ExampleMessage
@@ -74,14 +89,6 @@ vi.mock('@google-cloud/pubsub', () => {
 let subscriberFn: (args: { ack: Mock; nack: Mock; data: string }) => void
 
 const description = 'This is an example message'
-const zodValue = z.object(
-  {
-    messageType: z.string(),
-    message: z.number(),
-  },
-  { description }
-)
-const avroSchema = zodToAvro('ExampleMessage', zodValue)
 
 describe('when creating a new publisher client with no schema and publish a message', () => {
   it('should call the underlaying api with the correct values and message format', async () => {
@@ -96,7 +103,6 @@ describe('when creating a new publisher client with no schema and publish a mess
       projectId: 'test',
     })
 
-    const message = { messageType: 'TYPE', created: new Date().toISOString() }
     await client.topic('example').publish(message)
 
     expect(pubSubMock.topic).toBeCalledWith('example')
@@ -119,11 +125,10 @@ describe('when creating a new publisher client with schema that does not exist a
       projectId: 'test',
     })
 
-    const message = { messageType: 'TYPE', created: new Date().toISOString() }
     await client
       .topic('example', {
         schemaId: 'schemaId',
-        avroDefinition: JSON.stringify(exampleAvroSchema),
+        avroDefinition: exampleAvroSchema,
       })
       .publish(message)
     const schemaType = Type.forSchema(exampleAvroSchema)
@@ -152,7 +157,6 @@ describe('when creating a new publisher client with schema that does exist and p
       projectId: 'test',
     })
 
-    const message = { messageType: 'TYPE', created: new Date().toISOString() }
     await client
       .topic('example', {
         schemaId: 'schemaId-does-not-exist',

packages/pubsub/src/lib/publisher.ts

@@ -21,7 +21,7 @@ const syncTopicSchema = async (client: PubSub, cloudSchema: CloudSchema) => {
     )
   }
 
-  const schema = await client.schema(cloudSchema.schemaId)
+  const schema = client.schema(cloudSchema.schemaId)
 
   const exits = await schemaExists(client, cloudSchema.schemaId)
   if (exits) {
@@ -123,7 +123,7 @@ export const createPublisher = <T extends Record<string, unknown>>(
 
 const schemaExists = async (client: PubSub, schemaId: string) => {
   for await (const s of client.listSchemas()) {
-    if (s.name === schemaId) {
+    if (s.name?.endsWith(`/${schemaId}`)) {
       return true
     }
   }