Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call of install_nbextension #8

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Conversation

vinklein
Copy link
Contributor

@vinklein vinklein commented Jan 16, 2018

As jdemeyer stated in pari_jupyter PR5
install_nbextension seems to be buggy (on some config it try to install file under /usr/local/share/jupyter even with pip install --user option)
see (jupyter/notebook#1706).

  • Remove the call of install_nbextension
  • Use data_files instead with fixed path (old paths where wrongs)

As install_nbextension seems to be buggy
see (jupyter/notebook#1706).

- Remove the call of install_nbextension
- Use data_files instead with fixed path (old paths where wrongs)
@sebasguts sebasguts merged commit 6393850 into sebasguts:master Jan 24, 2018
@sebasguts
Copy link
Owner

Thank you :)

@vinklein
Copy link
Contributor Author

vinklein commented Jan 25, 2018

You're welcome.

Jdemeyer has also remove enable_extension() as explained in the end of pari_jupyter PR5.

In short it allows the extension to be auto enabled with Jupyter notebook version >= 5.3.
The drawback is that with previous version the extension must be manually enabled (with a command).

If you want to i can port this evolution to "jupyter_kernel_singular". Just tell me.
I think it would be nice to have the same behaviour accross ODK kernels.

@sebasguts
Copy link
Owner

Thank you, but I already did this :). I still have to update the readme, though.

@vinklein
Copy link
Contributor Author

Oh nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants