Throw an exception if code coverage fails to write to disk

sebastianbergmann · Sep 19, 2019 · 23c3be9 · 23c3be9
1 parent aa0d179
commit 23c3be9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -27,6 +27,7 @@
     "require": {
         "php": "^7.2",
         "ext-dom": "*",
+        "ext-libxml": "*",
         "ext-xmlwriter": "*",
         "phpunit/php-file-iterator": "^2.0.2",
         "phpunit/php-token-stream": "^3.1.1",

diff --git a/src/Report/Xml/Facade.php b/src/Report/Xml/Facade.php
@@ -277,7 +277,21 @@ private function saveDocument(\DOMDocument $document, string $name): void
         $document->preserveWhiteSpace = false;
         $this->initTargetDirectory(\dirname($filename));
 
-        $document->save($filename);
+        $original = \libxml_use_internal_errors(true);
+        $result   = $document->save($filename);
+
+        if ($result === false) {
+            $message = 'Unable to save the XML';
+
+            foreach (\libxml_get_errors() as $error) {
+                $message .= "\n" . $error->message;
+            }
+
+            throw new RuntimeException($message);
+        }
+
+        \libxml_clear_errors();
+        \libxml_use_internal_errors($original);
     }
 
     private function createDirectory(string $directory): bool