Encapsulate raw coverage data from drivers #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
============================================
+ Coverage 83.10% 83.25% +0.15%
- Complexity 834 845 +11
============================================
Files 35 37 +2
Lines 2450 2472 +22
============================================
+ Hits 2036 2058 +22
Misses 414 414
Continue to review full report at Codecov.
|
dvdoug
force-pushed
the
encapsulate_raw_data_from_drivers
branch
from
6208dce
to
b7957eb
Compare
dvdoug
force-pushed
the
encapsulate_raw_data_from_drivers
branch
from
b7957eb
to
46d3c0c
Compare
|
Thanks! I have made some minor adjustments after merging this. |
|
👍 |
| */ | ||
| private $lineData = []; | ||
|
|
||
| public function __construct(array $rawCoverage = []) |
There was a problem hiding this comment.
I do not like the fact that the constructor has to guess the format of the array passed in. Can we please make the constructor private and add separate static methods, named constructors, for each supported format? For instance: fromXdebugWithoutPathCoverage(), fromXdebugWithPathCoverage(), etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sebastianbergmann
Please find attached a PR for the first piece of the enabling work for #380. The goal of this particular PR is not to add new functionality, merely to lay groundwork.
What does this PR do?
arrayfromDriver->stop()with a new objectRawCodeCoverageData, with consequential adjustments to the rest of the codeCodeCoveragewith usage of named methods onRawCodeCoverageDataPlease note this PR does not adjust the internal
$this->dataarray used by theCodeCoverageclass. I do plan on encapsulating that too, but it will be in a different PR.