Remove preloading when using processUncoveredFiles #800
Conversation
As discussed in sebastianbergmann#799, this feature is no longer required because of Xdebug's built in filter
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
============================================
- Coverage 83.00% 82.93% -0.07%
+ Complexity 1114 1112 -2
============================================
Files 60 60
Lines 3413 3411 -2
============================================
- Hits 2833 2829 -4
- Misses 580 582 +2
Continue to review full report at Codecov.
|
| $this->addUncoveredFilesFromFilter(); | ||
| if (!$raw) { | ||
| if ($this->processUncoveredFiles) { | ||
| $this->processUncoveredFilesFromFilter(); |
There was a problem hiding this comment.
I've run the tests locally, and as codecov tells, there's no test that covers this line nor the processUncoveredFilesFromFilter method
|
After upgrading to PHPUnit 9.3.8 (and php-code-coverage 9.1.5) I started to have risky tests for this project: https://travis-ci.com/github/lcobucci/clock/jobs/378484206#L366 (the lines reported there are empty lines at the end of the files). Can it be related to this changeset? |
As discussed in #799, this feature is no longer required because of Xdebug's built in filter