Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use md5 for cache hashing instead of weak crc32 #931

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Use md5 for cache hashing instead of weak crc32 #931

merged 1 commit into from
Aug 30, 2022

Conversation

mvorisek
Copy link
Contributor

currently collision (with p=50%) is expected with sqrt(2*2^32*0.5) [1] = 65536 files only

[1] https://en.wikipedia.org/wiki/Birthday_problem#Square_approximation

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #931 (2e94d03) into 9.2 (2e94d03) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e94d03 differs from pull request most recent head 6116811. Consider uploading reports for the commit 6116811 to get more accurate results

@@            Coverage Diff            @@
##                9.2     #931   +/-   ##
=========================================
  Coverage     83.66%   83.66%           
  Complexity     1161     1161           
=========================================
  Files            59       59           
  Lines          3415     3415           
=========================================
  Hits           2857     2857           
  Misses          558      558           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann
Copy link
Owner

Looks like you started working on this before af80b77 and/or 2e94d03 and now there is a conflict. Can you please resolve it? Thanks!

@mvorisek
Copy link
Contributor Author

rebased

@sebastianbergmann sebastianbergmann merged commit a40afad into sebastianbergmann:9.2 Aug 30, 2022
@mvorisek mvorisek deleted the use_md5_instead_of_crc32 branch August 30, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants