In callback there is no "file" in trace

[DarkSide666]

In callback there is no "file" in trace.

For example, trace will look like

    [0] => Array
        (
            [file] => C:\wamp\www\atk4\validate\vendor\vlucas\valitron\src\Valitron\Validator.php
            [line] => 760
            [function] => strtotime
        )
    [1] => Array
        (
            [function] => validateDate
            [class] => Valitron\Validator
            [type] => ->
        )
    [2] => Array
        (
            [file] => C:\wamp\www\atk4\validate\vendor\vlucas\valitron\src\Valitron\Validator.php
            [line] => 1251
            [function] => call_user_func
        )
   ...

and [1] element has only function, class and type attributes, but no file and line.

[sebastianbergmann]

Thank you for your pull request.

Please include a minimal, self-contained, reproducing test case that shows the problem you are aiming to solve.

Also note that pull requests for bug fixes should not target main but the oldest release branch that still receives bug fixes where the problem exists.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (d724b7f) to head (d2a4b10).

Additional details and impacted files

@@            Coverage Diff            @@
##               11.1    #5822   +/-   ##
=========================================
  Coverage     89.86%   89.86%           
- Complexity     6560     6562    +2     
=========================================
  Files           693      693           
  Lines         19850    19850           
=========================================
  Hits          17838    17838           
  Misses         2012     2012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DarkSide666]

I've rebased this PR to 11.1 branch. In versions 10.x this is not relevant.

Speaking about tests I'm really not sure how to write proper one for phpunit.
This simple test class shows that in case debug_backtrace is called from callback method, then it do not contain file and line array keys. So asserting that file and line keys are always present in backtrace in phpunit ErrorHandler class is wrong and will throw error in such cases.

class MyTest extends TestCase
{
    public function testDebugBacktrace()
    {
        $result = $this->callUserFuncExample();

        // Check if the debug_backtrace has been generated
        $this->assertNotNull($result);

        // Check if the first element of the debug_backtrace is missing file and line elements
        $this->assertArrayHasKey('function', $result[0]);
        $this->assertArrayNotHasKey('file', $result[0]);
        $this->assertArrayNotHasKey('line', $result[0]);
    }

    private function callUserFuncExample()
    {
        return call_user_func([$this, 'exampleCallback']);
    }

    private function exampleCallback()
    {
        return debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 1);
    }
}

Can anyone please help me to write test for this for phpunit lib ?

[DarkSide666]

Added testcase which after fix will no more fail, but before fix fails.

[mvorisek]

@sebastianbergmann this PR should be retarget instead of closed

[sebastianbergmann]

@DarkSide666 I did not intend to close this. Please send a new PR against the 11.2 branch. Thanks!

[sebastianbergmann]

Merged manually into 11.2.