Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the frame's top position user configurable. #205

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

gyst
Copy link
Contributor

@gyst gyst commented Jan 16, 2024

This is my first lisp PR, so please be gentle ;-).

  • I'm using company-box together with copilot. I need to push the top of the company box frame down, so that the company box frame does not mask the first lines of copilot suggestions.
  • Even without copilot, using company-box on a base text with enlarged fonts benefits from adding extra vertical space

Without extra top margin:
image

With extra top margin set to 70:
image

@sebastiencs
Copy link
Owner

@gyst That looks good.

Even without copilot, using company-box on a base text with enlarged fonts benefits from adding extra vertical space

Can you add this use case to the documentation of company-box-frame-top-margin, and the link/URL to this pull request too ?

@gyst
Copy link
Contributor Author

gyst commented Jan 17, 2024

Sure. You mean the documentation on the defcustom, or elsewhere?

@gyst
Copy link
Contributor Author

gyst commented Jan 17, 2024

There was an issue about that use case, but I wasn't able to find it again.

gyst added a commit to gyst/company-box that referenced this pull request Jan 17, 2024
@sebastiencs
Copy link
Owner

Thanks @gyst

@sebastiencs sebastiencs merged commit c4f2e24 into sebastiencs:master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants