fix: allow X-attrs to be specified in constructor #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What
- whitelist `x` in constructor
## Why
- allow this to be specified via passed in object, for example:
```
ical({
domain: 'sebbo.net',
prodId: '//superman-industries.com//ical-generator//EN',
events: [
{
start: moment(),
end: moment().add(1, 'hour'),
timestamp: moment(),
summary: 'My Event',
organizer: 'Sebastian Pekarek <[email protected]>',
x: [
['LANGUAGE', 'en-GB']
]
}
]
});
```
bguiz
added a commit
to rsksmart/devportal-1.0
that referenced
this pull request
Mar 23, 2020
- make use of ical-generator - use prefix to specify yaml front matter containing permalink for jekyll - NOTE that X-attributes are not yet able to be specified in this manner - REF: sebbo2002/ical-generator#185
|
Thanks for your pull request, I just released 1.9.4 with your changes. Have a nice day! |
bguiz
added a commit
to rsksmart/devportal-1.0
that referenced
this pull request
Mar 29, 2020
sebbo2002
pushed a commit
that referenced
this pull request
Feb 27, 2021
# [1.3.0-develop.1](v1.2.1...v1.3.0-develop.1) (2021-02-27) ### Bug Fixes * **package.json:** add temporary version ([0bc117e](0bc117e)) * allow X-attrs to be specified in constructor ([#185](#185)) ([58c1ae5](58c1ae5)) * capitalize byDay even when bySetPos is used ([#205](#205)) ([5440fbc](5440fbc)) * **Typings:** Fix OPT-PARTICIPANT ([b777f9e](b777f9e)), closes [#192](#192) * Fix scale type for CalendarData ([#191](#191)) ([d5421e8](d5421e8)) * Make x key optional in types ([#211](#211)) ([e3c21e2](e3c21e2)) * Type fixes and updates ([#217](#217)) ([d8abe4d](d8abe4d)) ### Features * **Events:** Add appleLocation method ([#170](#170)) ([0956ba2](0956ba2)) * Add missing string input options to interface ([#199](#199)) ([a963178](a963178)) * Add Transparency Method ([bd2901d](bd2901d)) * Increase id entropy - Fixes [#200](#200) ([#202](#202)) ([6711b0a](6711b0a)) * make domain optional ([#209](#209)) ([e3362c9](e3362c9)) * Updated the entire codebase to Typescript ([d013dc0](d013dc0)) * **Events:** use provided timezone when constructing repeating.exclude ([#210](#210)) ([bd84230](bd84230))
|
🎉 This PR is included in version 1.3.0-develop.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Apr 10, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
xin constructorWhy