chore(linting): update codelyzer & tslint

sebholstein · Oct 31, 2017 · 0ce079e · 0ce079e
1 parent 305320a
commit 0ce079e
Show file tree

Hide file tree

Showing 7 changed files with 807 additions and 983 deletions.
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "angular2-template-loader": "^0.6.2",
     "awesome-typescript-loader": "3.1.2",
     "clang-format": "1.0.46",
-    "codelyzer": "3.0.0-beta.4",
+    "codelyzer": "^3.2.2",
     "conventional-changelog": "^1.1.0",
     "copy-webpack-plugin": "^4.0.1",
     "copyfiles": "^1.0.0",
@@ -93,7 +93,7 @@
     "rollup": "0.41.6",
     "rxjs": "^5.2.0",
     "ts-helpers": "^1.1.2",
-    "tslint": "~4.5.1",
+    "tslint": "^5.8.0",
     "tslint-loader": "^3.4.3",
     "typescript": "~2.2.0",
     "webpack": "2.3.3",

diff --git a/packages/core/core.module.ts b/packages/core/core.module.ts
@@ -22,7 +22,7 @@ export function coreDirectives() {
     AgmPolygon, AgmPolyline, AgmPolylinePoint, AgmKmlLayer,
     AgmDataLayer
   ];
-};
+}
 
 /**
  * The angular-google-maps core module. Contains all Directives/Services/Pipes

diff --git a/packages/core/services/managers/circle-manager.ts b/packages/core/services/managers/circle-manager.ts
@@ -30,7 +30,7 @@ export class CircleManager {
       visible: circle.visible,
       zIndex: circle.zIndex
     }));
-  };
+  }
 
   /**
    * Removes the given circle from the map.
@@ -44,15 +44,15 @@ export class CircleManager {
 
   setOptions(circle: AgmCircle, options: mapTypes.CircleOptions): Promise<void> {
     return this._circles.get(circle).then((c) => c.setOptions(options));
-  };
+  }
 
   getBounds(circle: AgmCircle): Promise<mapTypes.LatLngBounds> {
     return this._circles.get(circle).then((c) => c.getBounds());
-  };
+  }
 
   getCenter(circle: AgmCircle): Promise<mapTypes.LatLng> {
     return this._circles.get(circle).then((c) => c.getCenter());
-  };
+  }
 
   getRadius(circle: AgmCircle): Promise<number> {
     return this._circles.get(circle).then((c) => c.getRadius());
@@ -61,23 +61,23 @@ export class CircleManager {
   setCenter(circle: AgmCircle): Promise<void> {
     return this._circles.get(circle).then(
         (c) => { return c.setCenter({lat: circle.latitude, lng: circle.longitude}); });
-  };
+  }
 
   setEditable(circle: AgmCircle): Promise<void> {
     return this._circles.get(circle).then((c) => { return c.setEditable(circle.editable); });
-  };
+  }
 
   setDraggable(circle: AgmCircle): Promise<void> {
     return this._circles.get(circle).then((c) => { return c.setDraggable(circle.draggable); });
-  };
+  }
 
   setVisible(circle: AgmCircle): Promise<void> {
     return this._circles.get(circle).then((c) => { return c.setVisible(circle.visible); });
-  };
+  }
 
   setRadius(circle: AgmCircle): Promise<void> {
     return this._circles.get(circle).then((c) => { return c.setRadius(circle.radius); });
-  };
+  }
 
   createEventObservable<T>(eventName: string, circle: AgmCircle): Observable<T> {
     return Observable.create((observer: Observer<T>) => {

diff --git a/packages/core/services/maps-api-loader/noop-maps-api-loader.ts b/packages/core/services/maps-api-loader/noop-maps-api-loader.ts
@@ -12,5 +12,5 @@ export class NoOpMapsAPILoader implements MapsAPILoader {
           'Google Maps API not loaded on page. Make sure window.google.maps is available!');
     }
     return Promise.resolve();
-  };
+  }
 }
diff --git a/packages/snazzy-info-window/directives/snazzy-info-window.ts b/packages/snazzy-info-window/directives/snazzy-info-window.ts
@@ -1,4 +1,4 @@
-import { Host, SkipSelf, AfterViewInit, EventEmitter, Input, SimpleChanges, ViewContainerRef, TemplateRef, Output, Optional, OnDestroy, ElementRef, Component, ViewChild, ContentChild } from '@angular/core';
+import { Host, SkipSelf, OnChanges, AfterViewInit, EventEmitter, Input, SimpleChanges, ViewContainerRef, TemplateRef, Output, Optional, OnDestroy, ElementRef, Component, ViewChild, ContentChild } from '@angular/core';
 import { AgmMarker, GoogleMapsAPIWrapper, MarkerManager, MapsAPILoader } from '@agm/core';
 
 declare var System: any;
@@ -8,7 +8,7 @@ declare var System: any;
   selector: 'agm-snazzy-info-window',
   template: '<div #outerWrapper><div #viewContainer></div></div><ng-content></ng-content>'
 })
-export class AgmSnazzyInfoWindow implements AfterViewInit, OnDestroy {
+export class AgmSnazzyInfoWindow implements AfterViewInit, OnDestroy, OnChanges {
   /**
    * The latitude and longitude where the info window is anchored.
    * The offset will default to 0px when using this option. Only required/used if you are not using a agm-marker.

diff --git a/tslint.json b/tslint.json
@@ -57,9 +57,7 @@
       {
         "call-signature": "nospace",
         "index-signature": "nospace",
-        "parameter": "nospace",
-        "property-delcaration": "nospace",
-        "variable-delcaration": "nospace"
+        "parameter": "nospace"
       }
     ],
     "variable-name": [
@@ -74,7 +72,6 @@
       "check-decl",
       "check-operator",
       "check-separator",
-      "check-module",
       "check-type"
     ],
     "component-selector": [true, "element", "agm", "kebab-case"],